depotfmt: Some misformatted files aren't caught

#173
Opened by aspen at 2022-02-02T03·31+00

See eg https://buildkite.com/tvl/depot/builds/12277, which passed despite introducing a formatting issue; https://buildkite.com/tvl/depot/builds/12278#c711cefc-7980-4485-97ff-5d966cf23971 then failed properly

  1. What happened is likely that the CL was based on a patchset that did not include the formatting check yet, but otherwise applied fine and thus did not cause a merge conflict.

    This is a specific form of a more general issue with rebase order that we should apply some brainpower to.

    tazjin at 2022-02-02T11·01+00

  2. The fact that we haven't seen this again since leads me to believe that my theory above is correct. Lets close this and see if it ever reoccurs.

    tazjin at 2022-10-02T14·29+00

  3. tazjin closed this issue at 2022-10-02T14·29+00