gerrit: votes are not always copied after upgrade

#194
Opened by tazjin at 2022-09-18T19·42+00

After our recent Gerrit upgrade adventure (see b/187), there is an issue where Gerrit will sometimes not copy votes to new patchsets where it did before. (e.g. cl/6645)

I am reasonably confident that it now sometimes does this, just need to go and find a CL that proves it.

  1. https://cl.tvl.fyi/c/depot/+/6665 should fix this; Gerrit deprecated the old label config copyAnyScore/copyMinScore/copyMaxScore/copyAllScoresIf* configs and replaced them with a single "copyCondition" config we need to set.

    https://review.coreboot.org/Documentation/config-labels.html#label_copyAnyScore has the replacements in:

    copyAnyScore ==> is:ANY copyMinScore ==> is:MIN copyMaxScore ==> is:MAX copyAllScoresIfListOfFilesDidNotChange ==> is:ANY AND has:unchanged-files copyAllScoresOnMergeFirstParentUpdate ==> is:ANY AND changekind:MERGE_FIRST_PARENT_UPDATE copyAllScoresOnTrivialRebase ==> is:ANY AND changekind:TRIVIAL_REBASE copyAllScoresIfNoCodeChange ==> is:ANY AND changekind:NO_CODE_CHANGE copyAllScoresIfNoChange ==> is:ANY AND changekind:NO_CHANGE

    lukegb at 2022-09-18T19·54+00

  2. Blargh, let me try that again:

    https://cl.tvl.fyi/c/depot/+/6665 should fix this; Gerrit deprecated the old label config copyAnyScore/copyMinScore/copyMaxScore/copyAllScoresIf* configs and replaced them with a single "copyCondition" config we need to set.

    https://review.coreboot.org/Documentation/config-labels.html#label_copyAnyScore has the replacements in:

    • copyAnyScore ==> is:ANY copyMinScore ==> is:MIN copyMaxScore ==> is:MAX
    • copyAllScoresIfListOfFilesDidNotChange ==> is:ANY AND has:unchanged-files
    • copyAllScoresOnMergeFirstParentUpdate ==> is:ANY AND changekind:MERGE_FIRST_PARENT_UPDATE
    • copyAllScoresOnTrivialRebase ==> is:ANY AND changekind:TRIVIAL_REBASE
    • copyAllScoresIfNoCodeChange ==> is:ANY AND changekind:NO_CODE_CHANGE
    • copyAllScoresIfNoChange ==> is:ANY AND changekind:NO_CHANGE

    lukegb at 2022-09-18T19·54+00

  3. Fixed in https://cl.tvl.fyi/c/depot/+/6665

    lukegb at 2022-09-18T19·55+00

  4. lukegb closed this issue at 2022-09-18T19·55+00