Upgrade to Go 1.20
#215
Opened by sterni at
Current nixpkgs
defaults to Go 1.19, we need to stay with Go 1.18 for some parts of depot:
- Go 1.19 changed formatting, so we need to reformat Go code in depot
- //nix/buildGo doesn't work with Go 1.19, error message seems to be complaining about a missing
-p
flag, but I did not investigate more.
- sterni changed the subject of this issue from "treewide: upgrade to Go 1.19" to "Upgrade to Go 1.19" at 2022-10-31T13·56+00
- sterni updated the body of this issue at 2022-10-31T13·56+00
I tried with go 1.20, in the current nixpkgs checkout.
This time, it looks like it's not complaining about a missing
-p
flag, but it's unable to find imports from stdlib (for example in //tvix/boot:tvix-init`):/nix/store/w5gakq79i60j5wss71zhjlwnbpym8m84-tvix-init.go:4:2: could not import fmt (file not found) /nix/store/w5gakq79i60j5wss71zhjlwnbpym8m84-tvix-init.go:5:2: could not import log (file not found) /nix/store/w5gakq79i60j5wss71zhjlwnbpym8m84-tvix-init.go:6:2: could not import os (file not found) /nix/store/w5gakq79i60j5wss71zhjlwnbpym8m84-tvix-init.go:7:2: could not import os/exec (file not found) /nix/store/w5gakq79i60j5wss71zhjlwnbpym8m84-tvix-init.go:8:2: could not import strings (file not found) /nix/store/w5gakq79i60j5wss71zhjlwnbpym8m84-tvix-init.go:9:2: could not import syscall (file not found)
flokli at 2023-09-26T06·44+00
- sterni changed the subject of this issue from "Upgrade to Go 1.19" to "Upgrade to Go 1.20-0" at 2023-11-16T17·10+00
- sterni changed the subject of this issue from "Upgrade to Go 1.20-0" to "Upgrade to Go 1.20" at 2023-11-16T17·10+00
-
sterni at 2024-02-12T16·03+00
- sterni closed this issue at 2024-02-12T16·03+00