buildGo.protos doesn't work with multiple related .proto files
If you have multiple .proto files that import each other, there's no way to express this with buildGo.protos
.
- you can't specify search paths for imports (
-I
passed toprotoc
) - you can't specify multiple .proto files to include, or a directory to include
IMO, buildGo.protos was a mistake and should be removed. We should instead just generate the protos in a derivation and use those as the source in a normal buildGo call.
tazjin at 2022-12-03T13·27+00
I'm still more in favor of having the generated .pb.go files in the repository, and a linter ensuring consistency, but let's see how this all works out.
c/7536 removes buildGo.proto and buildGo.grpc as proposed here.
flokli at 2022-12-06T15·16+00
Turns out we can't use this just yet, as depot-scanner still uses this.
@tazjin should we move this to generated .pb.go files?
flokli at 2022-12-06T15·20+00
We've deleted this.
tazjin at 2023-01-08T11·23+00
- tazjin closed this issue at 2023-01-08T11·23+00