//tvix/store.Directory::validate should have some proptests

#233
Opened by flokli at 2022-12-28T10·53+00

This function validates a Directory message to be valid.

We can probably reduce some of the boilerplace from cl/7650 by using proptests.

  1. I decided to take a look at this. If anyone has any thoughts or opinion about it, feel free to reach out.

    Also, if it's not closed in the next few weeks, then I probably forgot about it or became otherwise busy and you're welcome to pick it up.

    benjaminedwardwebb at 2024-08-09T22·15+00

  2. The Directory struct has been moved to a version where invalid states become impossible to represent (as all validations are expressed on the type level, at least if we didn't forget anything).

    I'm not sure we can add much more to this. Closing for now.

    flokli at 2024-11-01T23·56+00

  3. flokli closed this issue at 2024-11-01T23·56+00

  4. FWIW I did end up doing some work to write property tests for the functions that parse the protobuf data into the Directory struct, but it required more boilerplate than ultimately seemed worth it. I agree there's probably not much to be gained by adding them in addition to the existing unit tests.

    benjaminedwardwebb at 2025-02-04T02·28+00