tvix: EvalIO: tvix_eval::errors::ErrorKind doesn't make sense
#271
Opened by flokli at
The only useful error we can raise from there is ErrorKind::IO (and maybe ErrorKind::WithContext).
The former one simply adds a PathBuf to an io::Error, and that's something the caller of EvalIO already knows (as it passed it in).
We should probably replace the errors in the interface with io::Error directly.
Spun out of https://cl.tvl.fyi/c/depot/+/8561/comment/d9be5371_65db5dd0/.
Implemented in cl/8602. Also, some of the interface got updated to only use
&Path
in cl/8604, meaning less cloning on the callsites.flokli at 2023-05-21T08·58+00
The CLs were merged, this can be closed.
flokli at 2023-05-22T10·59+00
- flokli closed this issue at 2023-05-22T11·00+00