josh: fix pushing subtrees through josh to gerrit

#318
Opened by flokli at 2023-10-11T15·39+00

cl/9591 fixed pushing to gerrit from clones josh subtrees (for contributors working only in a subtree/workspace), by setting josh's --remote arg to https://cl.tvl.fyi/a.

However, this breaks anonymous cloning, so it was subsequently reverted in cl/9625.

Ideally, we should be able to configure separate push and pull URLs in Josh.

Another idea I had might be to have two instances of josh running, one for pushes, one for pulls (and dispatching in our nginx config to one of them depending on the HTTP method, assuming the protocol allows this), but I'm also not too sure about the state in /var/lib/josh - can we share it / is it ok to have two of these, one for each process?

  1. But the problem is not related to authentication? Something in the pipeline is causing server errors from josh.

    Why do you think it's auth? What changed that could have broken auth?

    tazjin at 2023-10-11T15·50+00

  2. This is currently working fine, whatever the problem was (which is not related to auth) has disappeared.

    I pushed an empty test CL: https://cl.tvl.fyi/c/depot/+/9685

    And a non-empty one: https://cl.tvl.fyi/c/depot/+/9686

    Both through josh, with no problems.

    tazjin at 2023-10-11T20·59+00

  3. And another one, on a workspace: https://cl.tvl.fyi/c/depot/+/9687

    Whatever broke has seemingly fixed itself.

    tazjin at 2023-10-11T21·01+00

  4. Maybe it was the v4-only listening too. In any case, this seems to work now, so let's close it.

    flokli at 2023-10-14T12·07+00

  5. flokli closed this issue at 2023-10-14T12·07+00